pgsql: Assume that we have utime() and <utime.h>.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Assume that we have utime() and <utime.h>.
Date: 2020-02-21 19:31:40
Message-ID: E1j5E1U-0003kr-7E@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Assume that we have utime() and <utime.h>.

These are required by POSIX since SUSv2, and no live platforms fail
to provide them. On Windows, utime() exists and we bring our own
<utime.h>, so we're good there too. So remove the configure probes
and ad-hoc substitute code. We don't need to check for utimes()
anymore either, since that was only used as a substitute.

In passing, make the Windows build include <sys/utime.h> only where
we need it, not everywhere.

This is part of a series of commits to get rid of no-longer-relevant
configure checks and dead src/port/ code. I'm committing them separately
to make it easier to back out individual changes if they prove less
portable than I expect.

Discussion: https://postgr.es/m/15379.1582221614@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/481c8e9232386e289fbd3e8f75893ae8d9814298

Modified Files
--------------
configure | 4 ++--
configure.in | 3 ---
src/backend/libpq/pqcomm.c | 18 ++----------------
src/backend/utils/init/miscinit.c | 27 ++-------------------------
src/include/pg_config.h.in | 9 ---------
src/include/port/win32_msvc/utime.h | 2 ++
src/include/port/win32_port.h | 1 -
src/tools/msvc/Solution.pm | 3 ---
8 files changed, 8 insertions(+), 59 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-02-21 19:58:43 pgsql: Allow running src/tools/msvc/mkvcbuild.pl under not Windows
Previous Message Peter Eisentraut 2020-02-21 19:02:27 pgsql: Fix compiler warnings on 64-bit Windows