| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Minor refactor of nodeAgg.c. |
| Date: | 2020-02-19 18:53:40 |
| Message-ID: | E1j4UTc-0003y6-09@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Minor refactor of nodeAgg.c.
* Separate calculation of hash value from the lookup.
* Split build_hash_table() into two functions.
* Change lookup_hash_entry() to return AggStatePerGroup. That's all
the caller needed, anyway.
These changes are to support the upcoming Disk-based Hash Aggregation
work.
Discussion: https://postgr.es/m/31f5ab871a3ad5a1a91a7a797651f20e77ac7ce3.camel%40j-davis.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/5b618e1f48aecc66e3a9f60289491da520faae19
Modified Files
--------------
src/backend/executor/nodeAgg.c | 140 ++++++++++++++++++++++++++---------------
1 file changed, 89 insertions(+), 51 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-02-19 19:18:04 | pgsql: Set gen_random_uuid() to volatile |
| Previous Message | Jeff Davis | 2020-02-19 18:12:23 | pgsql: logtape.c: allocate read buffer even for an empty tape. |