| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fill in extraUpdatedCols in logical replication |
| Date: | 2020-02-17 15:14:11 |
| Message-ID: | E1j3i67-0002Ne-0V@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fill in extraUpdatedCols in logical replication
The extraUpdatedCols field of the target RTE records which generated
columns are affected by an update. This is used in a variety of
places, including per-column triggers and foreign data wrappers. When
an update was initiated by a logical replication subscription, this
field was not filled in, so such an update would not affect generated
columns in a way that is consistent with normal updates. To fix,
factor out some code from analyze.c to fill in extraUpdatedCols in the
logical replication worker as well.
Reviewed-by: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/b05e781a-fa16-6b52-6738-761181204567(at)2ndquadrant(dot)com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/4a97f647ddbc79af2fb91727d4a2502ce667d0fd
Modified Files
--------------
src/backend/parser/analyze.c | 18 ++++++++++++------
src/backend/replication/logical/worker.c | 3 +++
src/include/parser/analyze.h | 2 ++
3 files changed, 17 insertions(+), 6 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-02-17 23:40:28 | pgsql: Teach pg_dump to dump comments on RLS policy objects. |
| Previous Message | Peter Eisentraut | 2020-02-17 15:14:10 | pgsql: Fill in extraUpdatedCols in logical replication |