pgsql: Fix bug in pg_basebackup -F plain -R.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bug in pg_basebackup -F plain -R.
Date: 2020-02-12 00:13:02
Message-ID: E1j1feI-0003ny-Id@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bug in pg_basebackup -F plain -R.

Commit caba97a9d9 changed pg_basebackup -F plain -R so that
it overwrote postgresql.auto.conf in the backup, with new connection
setting. This could cause the existing postgresql.auto.conf settings
in the server to get lost unexpectedly. This is a bug.

This commit fixes the bug by making pg_basebackup -F plain -R
append the connection setting into postgresql.auto.conf in the backup.

Author: Fujii Masao
Reviewed-by: Sergei Kornilov
Discussion: https://postgr.es/m/250dcf2a-94e7-c05e-824a-73cfb38a48a4@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/be6221e9be234109aa261ea767c85f5e8cda90e8

Modified Files
--------------
src/fe_utils/recovery_gen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-02-12 00:43:09 pgsql: Test additional speculative conflict scenarios.
Previous Message noreply 2020-02-11 23:13:20 pgsql: Tag refs/tags/REL9_5_21 was created