pgsql: Allow building without default socket directory

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Allow building without default socket directory
Date: 2020-01-31 15:48:22
Message-ID: E1ixYWs-0007nP-IC@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Allow building without default socket directory

We have code paths for Unix socket support and no Unix socket support.
Now add a third variant: Unix socket support but do not use a Unix
socket by default in the client or the server, only if you explicitly
specify one. This will be useful when we enable Unix socket support
on Windows.

To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR
to "" has the desired effect. This mostly already worked like that;
only a few places needed to be adjusted. Notably, the reference to
DEFAULT_PGSOCKET_DIR in UNIXSOCK_PATH() could be removed because all
callers already resolve an empty socket directory setting with a
default if appropriate.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/75f72249-8ae6-322a-63df-4fe03eeccb9f@2ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a9cff89f7e638c060621a62ca35da97a12adde42

Modified Files
--------------
src/include/libpq/pqcomm.h | 6 +++---
src/include/pg_config_manual.h | 5 +++++
src/interfaces/libpq/fe-connect.c | 15 ++++++++++-----
3 files changed, 18 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-31 19:42:16 pgsql: Fix parallel pg_dump/pg_restore for failure to create worker pro
Previous Message Peter Eisentraut 2020-01-31 11:55:02 pgsql: Sprinkle some const decorations