From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: In jsonb_plpython.c, suppress warning message from gcc 10. |
Date: | 2020-01-30 23:26:31 |
Message-ID: | E1ixJCh-0002Cl-JC@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
In jsonb_plpython.c, suppress warning message from gcc 10.
Very recent gcc complains that PLyObject_ToJsonbValue could return
a pointer to a local variable. I think it's wrong; but the coding
is fragile enough, and the savings of one palloc() minimal enough,
that it seems better to just do a palloc() all the time. (My other
idea of tweaking the if-condition doesn't suppress the warning.)
Back-patch to v11 where this code was introduced.
Discussion: https://postgr.es/m/21547.1580170366@sss.pgh.pa.us
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a4484a6489291d3160767d57ab538f1de6698c21
Modified Files
--------------
contrib/jsonb_plpython/jsonb_plpython.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2020-01-31 04:32:17 | pgsql: Adjust DSM and DSA slot usage constants. |
Previous Message | Thomas Munro | 2020-01-30 22:34:35 | pgsql: Handle lack of DSM slots in parallel btree build. |