pgsql: Avoid unnecessary shm writes in Parallel Hash Join.

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Avoid unnecessary shm writes in Parallel Hash Join.
Date: 2020-01-27 02:07:58
Message-ID: E1ivtok-0007pG-Il@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Avoid unnecessary shm writes in Parallel Hash Join.

Currently, Parallel Hash Join cannot be used for full/right joins,
so there is no point in setting the match flag. It turns out that
the cache coherence traffic generated by those writes slows down
large systems running many-core joins, so let's stop doing that.
In future, if we need to use match bits in parallel joins, we might
want to consider setting them only if not already set.

Back-patch to 11, where Parallel Hash Join arrived.

Reported-by: Deng, Gang
Discussion: https://postgr.es/m/0F44E799048C4849BAE4B91012DB910462E9897A%40SHSMSX103.ccr.corp.intel.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3e4818e9dd5be294d97ca67012528cb1c0b0ccaa

Modified Files
--------------
src/backend/executor/nodeHashjoin.c | 21 ++++++++++++++++++++-
1 file changed, 20 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2020-01-27 02:08:13 pgsql: Avoid unnecessary shm writes in Parallel Hash Join.
Previous Message Michael Paquier 2020-01-27 02:03:11 pgsql: Fix some memory leaks and improve restricted token handling on W