pgsql: Fix EXPLAIN (SETTINGS) to follow policy about when to print empt

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix EXPLAIN (SETTINGS) to follow policy about when to print empt
Date: 2020-01-26 21:32:30
Message-ID: E1ivpWA-0003Ag-Pu@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix EXPLAIN (SETTINGS) to follow policy about when to print empty fields.

In non-TEXT output formats, the "Settings" field should appear when
requested, even if it would be empty.

Also, get rid of the premature optimization of counting all the
GUC_EXPLAIN variables at startup. Since there was no provision for
adjusting that count later, all it'd take would be some extension marking
a parameter as GUC_EXPLAIN to risk an assertion failure or memory stomp.
We could make get_explain_guc_options() count those variables on-the-fly,
or dynamically resize its array ... but TBH I do not think that making a
transient array of pointers a bit smaller is worth any extra complication,
especially when you consider all the other transient space EXPLAIN eats.
So just allocate that array at the max possible size.

In HEAD, also add some regression test coverage for this feature.

Because of the memory-stomp hazard, back-patch to v12 where this
feature was added.

Discussion: https://postgr.es/m/19416.1580069629@sss.pgh.pa.us

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bad494380210a76071485c5d8624334c4389dd88

Modified Files
--------------
src/backend/commands/explain.c | 18 ++++++--------
src/backend/utils/misc/guc.c | 54 ++++++++++++------------------------------
2 files changed, 22 insertions(+), 50 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-01-27 02:03:11 pgsql: Fix some memory leaks and improve restricted token handling on W
Previous Message Thomas Munro 2020-01-26 20:16:36 pgsql: Refactor confusing code in _mdfd_openseg().