pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix pg_dump's sigTermHandler() to use _exit() not exit().
Date: 2020-01-20 17:57:43
Message-ID: E1itbJ1-0002mK-AQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix pg_dump's sigTermHandler() to use _exit() not exit().

sigTermHandler() tried to be careful to invoke only operations that
are safe to do in a signal handler. But for some reason we forgot
that exit(3) is not among those, because it calls atexit handlers
that might do various random things. (pg_dump itself installs no
atexit handlers, but e.g. OpenSSL does.) That led to crashes or
lockups when attempting to terminate a parallel dump or restore
via a signal.

Fix by calling _exit() instead.

Per bug #16199 from Raúl Marín. Back-patch to all supported branches.

Discussion: https://postgr.es/m/16199-cb2f121146a96f9b@postgresql.org

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/4ea5cf403824e98932aa17c1c00f9c5241daf89d

Modified Files
--------------
src/bin/pg_dump/parallel.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-20 19:27:04 pgsql: Further tweaking of jsonb_set_lax().
Previous Message Andrew Dunstan 2020-01-20 09:00:34 Re: pgsql: Allow 'sslkey' and 'sslcert' in postgres_fdw user mappings