From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_stat_activity: show NULL stmt start time for walsenders |
Date: | 2020-01-07 21:13:07 |
Message-ID: | E1iow9z-0003SR-7s@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_stat_activity: show NULL stmt start time for walsenders
Returning a non-NULL time is pointless, sinc a walsender is not a
process that would be running normal transactions anyway, but the code
was unintentionally exposing the process start time intermittently,
which was not only bogus but it also confused monitoring systems looking
for idle transactions. Fix by avoiding all updates in walsenders.
Backpatch to pg10: previously I misidentified the branches that show
auxiliary processes in pg_stat_activity.
Reported-by: Tomas Vondra
Discussion: https://postgr.es/m/20191209234409.exe7osmyalwkt5j4@development
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/8de3b68faffcb5898244bd8af3abfb6edb11543f
Modified Files
--------------
src/backend/access/transam/xact.c | 7 +++++++
1 file changed, 7 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2020-01-07 21:16:24 | Re: pgsql: pg_stat_activity: show NULL stmt start time for walsenders |
Previous Message | Alvaro Herrera | 2020-01-07 20:50:45 | pgsql: pg_stat_activity: show NULL stmt start time for walsenders |