From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix yet another crash in page split during GiST index creation. |
Date: | 2019-12-16 12:00:23 |
Message-ID: | E1igp31-0005lV-Q8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix yet another crash in page split during GiST index creation.
Commit a7ee7c8513 fixed a bug in GiST page split during index creation,
where we failed to re-find the position of a downlink after the page
containing it was split. However, that fix was incomplete; the other call
to gistinserttuples() in the same function needs to also clear
'downlinkoffnum'.
Fixes bug #16134 reported by Alexander Lakhin, for real this time. The
previous fix was enough to fix the crash with the reproducer script for
bug #16162, but the original script for #16134 was still crashing.
Backpatch to v12, like the previous incomplete fix.
Discussion: https://www.postgresql.org/message-id/d869f537-abe4-d2ea-0510-38cd053f5152%40gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/741b884353e4803abc15d4392ad287b0d5953fc4
Modified Files
--------------
src/backend/access/gist/gist.c | 31 +++++++++++++++++++------------
1 file changed, 19 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-12-16 17:24:37 | pgsql: Demote variable from global to local |
Previous Message | Peter Eisentraut | 2019-12-16 10:53:17 | pgsql: Fix build of Perl-using modules of Windows |