pgsql: Improve test coverage of ruleutils.c.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve test coverage of ruleutils.c.
Date: 2019-12-06 22:40:43
Message-ID: E1idMHD-00026W-Vf@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve test coverage of ruleutils.c.

While fooling around with the EXPLAIN improvements I've been working
on, I noticed that there were some large gaps in our test coverage
of ruleutils.c, according to the code coverage report. This commit
just adds a few test cases to improve coverage of:
get_name_for_var_field()
get_update_query_targetlist_def()
isSimpleNode()
get_sublink_expr()

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/830d1c73b3f4524bc897ddab5c6c3b47840c915a

Modified Files
--------------
src/test/regress/expected/create_view.out | 103 +++++++++++++++++++++++++++++-
src/test/regress/expected/rules.out | 24 +++++++
src/test/regress/sql/create_view.sql | 35 ++++++++++
src/test/regress/sql/rules.sql | 11 ++++
4 files changed, 172 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2019-12-07 14:24:03 pgsql: Remove PQsslpassword function
Previous Message Jeff Davis 2019-12-06 20:02:55 pgsql: Fix comments in execGrouping.c