| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix failures with TAP tests of pg_ctl on Windows |
| Date: | 2019-12-03 04:02:23 |
| Message-ID: | E1ibzOJ-0002Wp-W1@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix failures with TAP tests of pg_ctl on Windows
On Windows, all the hosts spawned by the TAP tests bind to 127.0.0.1.
Hence, if there is a port conflict, starting a cluster would immediately
fail. One of the test scripts of pg_ctl initializes a node without
PostgresNode.pm, using the default port 5432. This could cause
unexpected startup failures in the tests if an independent server was up
and running on the same host (the reverse is also possible, though more
unlikely). Fix this issue by assigning properly a free port to the node
configured, in the same range used as for the other nodes part of the
tests.
Author: Michael Paquier
Reviewed-by: Andrew Dunstan
Discussion: https://postgr.es/m/20191202031444.GC1696@paquier.xyz
Backpatch-through: 11
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/ef30975b49702f9f8aaed7b1cd8f78470ed1b22d
Modified Files
--------------
src/bin/pg_ctl/t/001_start_stop.pl | 2 ++
1 file changed, 2 insertions(+)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-03 04:02:24 | pgsql: Fix failures with TAP tests of pg_ctl on Windows |
| Previous Message | Tom Lane | 2019-12-03 00:08:19 | pgsql: Fix EXPLAIN's column alias output for mismatched child tables. |