pgsql: Refactor query cancellation code into src/fe_utils/

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor query cancellation code into src/fe_utils/
Date: 2019-12-02 02:21:05
Message-ID: E1ibbKj-00048D-JM@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor query cancellation code into src/fe_utils/

Originally, this code was duplicated in src/bin/psql/ and
src/bin/scripts/, but it can be useful for other frontend applications,
like pgbench. This refactoring offers the possibility to setup a custom
callback which would get called in the signal handler for SIGINT or when
the interruption console events happen on Windows.

Author: Fabien Coelho, with contributions from Michael Paquier
Reviewed-by: Álvaro Herrera, Ibrar Ahmed
Discussion: https://postgr.es/m/alpine.DEB.2.21.1910311939430.27369@lancre

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a4fd3aa719e8f97299dfcf1a8f79b3017e2b8d8b

Modified Files
--------------
src/bin/psql/command.c | 1 +
src/bin/psql/common.c | 187 +++++------------------------------
src/bin/psql/common.h | 5 +-
src/bin/psql/large_obj.c | 7 +-
src/bin/psql/startup.c | 2 +-
src/bin/scripts/clusterdb.c | 2 +-
src/bin/scripts/common.c | 147 ---------------------------
src/bin/scripts/common.h | 7 +-
src/bin/scripts/reindexdb.c | 2 +-
src/bin/scripts/vacuumdb.c | 2 +-
src/fe_utils/Makefile | 1 +
src/fe_utils/cancel.c | 225 ++++++++++++++++++++++++++++++++++++++++++
src/include/fe_utils/cancel.h | 30 ++++++
src/tools/msvc/Mkvcbuild.pm | 2 +-
14 files changed, 294 insertions(+), 326 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-12-02 02:53:57 pgsql: Add query cancellation capabilities in pgbench init phase
Previous Message Michael Paquier 2019-12-02 01:56:28 Re: pgsql: libq support for sslpassword connection param, DER format keys