| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix closing stdin in TestLib.pm |
| Date: | 2019-11-26 21:33:01 |
| Message-ID: | E1iZiSD-0004TM-2D@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix closing stdin in TestLib.pm
Commit 9af34f3c6b naively assumed that all non-windows platforms would
have pseudoterminals and that perl would have IO::Pty. Such is not the
case. Instead of assumung anything, test for the presence of IO::Pty and
only use code that might depend on it if it's present. The test result is
exposed in $TestLib::have_io_pty so that it can be conveniently used in
SKIP tests.
Discussion: https://postgr.es/m/20191126044110.GB5435@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/792dba73c8f30528e51c4967d3be8ec4bdc5234b
Modified Files
--------------
src/test/perl/TestLib.pm | 28 +++++++++++++++++++---------
1 file changed, 19 insertions(+), 9 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2019-11-26 22:08:50 | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |
| Previous Message | Tom Lane | 2019-11-26 20:30:54 | Re: pgsql: Close stdin where it's not needed in TestLib.pm procedures |