pgsql: Improve test coverage for LISTEN/NOTIFY.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve test coverage for LISTEN/NOTIFY.
Date: 2019-11-23 22:30:26
Message-ID: E1iYdv8-0002TL-Vr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve test coverage for LISTEN/NOTIFY.

Back-patch commit b10f40bf0 into older branches. This adds reporting
of NOTIFY messages to isolationtester.c, and extends the async-notify
test to include direct tests of basic NOTIFY functionality.

This provides useful infrastructure for testing a bug fix I'm about
to back-patch, and there seems no good reason not to have better tests
of LISTEN/NOTIFY in the back branches. The commit's survived long
enough in HEAD to make it unlikely that it will cause problems.

Back-patch as far as 9.6. isolationtester.c changed too much in 9.6
to make it sane to try to fix older branches this way, and I don't
really want to back-patch those changes too.

Discussion: https://postgr.es/m/31304.1564246011@sss.pgh.pa.us

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/34f66c0ed800f50ffa75d57c7769f07d0adb5e29

Modified Files
--------------
src/test/isolation/expected/async-notify.out | 97 ++++++++++++++++++++++++++--
src/test/isolation/isolationtester.c | 88 +++++++++++++++----------
src/test/isolation/specs/async-notify.spec | 76 +++++++++++++++++++---
3 files changed, 211 insertions(+), 50 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-11-23 22:30:27 pgsql: Improve test coverage for LISTEN/NOTIFY.
Previous Message Alvaro Herrera 2019-11-23 16:22:08 pgsql: Remove debugging aid