From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Pass ItemPointer not HeapTuple to IndexBuildCallback. |
Date: | 2019-11-08 19:58:08 |
Message-ID: | E1iTAOW-0004lJ-Kv@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Pass ItemPointer not HeapTuple to IndexBuildCallback.
Not all AMs use HeapTuples internally, making it inconvenient to pass
a HeapTuple. As the index callbacks really only need the TID, not the
full tuple, modify callback to only take ItemPointer.
Author: Ashwin Agrawal
Reviewed-By: Andres Freund
Discussion: https://postgr.es/m/CALfoeis6=8ehuR=VNtHvj3z16cYfCwPdTcpaxU+sfSUJ5QgR3g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/aae50236e4ce95c05a3962be0814c74c5a22206d
Modified Files
--------------
contrib/amcheck/verify_nbtree.c | 6 +++---
contrib/bloom/blinsert.c | 4 ++--
src/backend/access/brin/brin.c | 4 ++--
src/backend/access/gin/gininsert.c | 5 ++---
src/backend/access/gist/gistbuild.c | 6 +++---
src/backend/access/hash/hash.c | 9 ++++-----
src/backend/access/heap/heapam_handler.c | 13 ++++++-------
src/backend/access/nbtree/nbtsort.c | 8 ++++----
src/backend/access/spgist/spginsert.c | 4 ++--
src/include/access/tableam.h | 2 +-
10 files changed, 29 insertions(+), 32 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2019-11-08 22:29:58 | Re: pgsql: Add backtrace support for error reporting |
Previous Message | Alvaro Herrera | 2019-11-08 18:52:20 | pgsql: Add backtrace support for error reporting |