pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.

From: Etsuro Fujita <efujita(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: postgres_fdw: Fix error message for PREPARE TRANSACTION.
Date: 2019-11-08 08:15:27
Message-ID: E1iSzQV-0001YI-H0@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

postgres_fdw: Fix error message for PREPARE TRANSACTION.

Currently, postgres_fdw does not support preparing a remote transaction
for two-phase commit even in the case where the remote transaction is
read-only, but the old error message appeared to imply that that was not
supported only if the remote transaction modified remote tables. Change
the message so as to include the case where the remote transaction is
read-only.

Also fix a comment above the message.

Also add a note about the lack of supporting PREPARE TRANSACTION to the
postgres_fdw documentation.

Reported-by: Gilles Darold
Author: Gilles Darold and Etsuro Fujita
Reviewed-by: Michael Paquier and Kyotaro Horiguchi
Backpatch-through: 9.4
Discussion: https://postgr.es/m/08600ed3-3084-be70-65ba-279ab19618a5%40darold.net

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/0cc31cc32da0ff6b3569eb73249eb1549b8731d1

Modified Files
--------------
contrib/postgres_fdw/connection.c | 16 ++++++++--------
doc/src/sgml/postgres-fdw.sgml | 6 ++++++
2 files changed, 14 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2019-11-08 17:40:42 pgsql: Fix gratuitous error message variation
Previous Message Peter Eisentraut 2019-11-08 07:17:46 pgsql: More precise errors from initial pg_control check