| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Add some assertions in syncrep.c |
| Date: | 2019-11-01 14:00:16 |
| Message-ID: | E1iQXTM-0008Ov-Ni@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Add some assertions in syncrep.c
A couple of routines assume that the LWLock SyncRepLock needs to be
taken, so add a couple of assertions to be sure of that. Also, when
waiting for a given LSN at transaction commit, the code implied that the
syncrep queue cleanup happens while holding interrupts, but the code
never checked after that.
Author: Michael Paquier
Reviewed-by: Fujii Masao, Kyotaro Horiguchi, Dongming Liu
Discussion: https://postgr.es/m/a0806273-8bbb-43b3-bbe1-c45a58f6ae21.lingce.ldm@alibaba-inc.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e174f699c476a4cc01875211a5f43e57c3190a37
Modified Files
--------------
src/backend/replication/syncrep.c | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-11-02 05:18:42 | pgsql: Fix failure when creating cloned indexes for a partition |
| Previous Message | Michael Paquier | 2019-11-01 13:39:49 | pgsql: Fix race condition at backend exit when deleting element in sync |