From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: On Windows, use COMSPEC to find the location of cmd.exe. |
Date: | 2019-10-28 18:15:08 |
Message-ID: | E1iP9Xo-00035j-R6@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Windows, use COMSPEC to find the location of cmd.exe.
Historically, psql consulted COMSPEC to spawn a shell in its \! command,
but we just invoked "cmd" when spawning shells in pg_ctl and pg_regress.
It seems better to rely on the environment variable, if it's set,
in all cases.
It's debatable whether this is a bug fix or just a behavioral change,
so no back-patch.
Juan José Santamaría Flecha
Discussion: https://postgr.es/m/16080-5d7f03222469f717@postgresql.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f88544904e4b57b1a8e969a5d594288554417c88
Modified Files
--------------
src/bin/pg_ctl/pg_ctl.c | 14 ++++++++++----
src/test/regress/pg_regress.c | 8 +++++++-
2 files changed, 17 insertions(+), 5 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-10-28 19:08:30 | pgsql: Allow extracting fields from a ROW() expression in more cases. |
Previous Message | Tom Lane | 2019-10-28 16:21:21 | pgsql: Handle empty-string edge cases correctly in strpos(). |