| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: For PowerPC instruction "addi", use constraint "b". |
| Date: | 2019-10-19 03:27:18 |
| Message-ID: | E1iLfOg-0005hX-Dd@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
For PowerPC instruction "addi", use constraint "b".
Without "b", a variant of the tas() code miscompiles on macOS 10.4.
This may also fix a compilation failure involving macOS 10.1. Today's
compilers have been allocating acceptable registers with or without this
change, but this future-proofs the code by precisely conveying the
acceptable registers. Back-patch to 9.4 (all supported versions).
Reviewed by Tom Lane.
Discussion: https://postgr.es/m/20191009063900.GA4066266@rfd.leadboat.com
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/62e881946c4d15f779808991f97ea379263a591d
Modified Files
--------------
src/include/storage/s_lock.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2019-10-19 16:38:53 | pgsql: Fix most -Wundef warnings |
| Previous Message | Michael Paquier | 2019-10-19 02:25:46 | pgsql: Remove last traces of heap_open/close in the tree |