From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | pgadmin-hackers(at)lists(dot)postgresql(dot)org |
Subject: | pgAdmin 4 commit: popen() function strips the quotes from the arguments |
Date: | 2019-10-10 12:30:09 |
Message-ID: | E1iIXa5-0002mz-8b@gothos.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
popen() function strips the quotes from the arguments, so backup fails
for the schema name that needs quoting.
Code is changed to add escapers.
Fixes #4590
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d056a94f0c30b44c4bab680a63f318de3226e958
Author: Aditya Toshniwal <aditya(dot)toshniwal(at)enterprisedb(dot)com>
Modified Files
--------------
docs/en_US/release_notes_4_14.rst | 1 +
web/pgadmin/misc/bgprocess/__init__.py | 15 ++++++++++
web/pgadmin/misc/bgprocess/process_executor.py | 32 ++++++++++++++++++----
.../setup/tests/test_export_import_servers.py | 4 +--
web/pgadmin/tools/backup/__init__.py | 15 +++++++---
5 files changed, 55 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Akshay Joshi | 2019-10-10 12:30:30 | Re: [pgAdmin][RM4590] Schema Backup fails with names that requires quoting |
Previous Message | Akshay Joshi | 2019-10-10 06:39:05 | Re: [pgAdmin][RM4701] Webpack optimization |