From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Add isolation tests for the combination of EPQ and triggers. |
Date: | 2019-10-04 21:37:09 |
Message-ID: | E1iGVG9-0001LU-0r@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add isolation tests for the combination of EPQ and triggers.
As evidenced by bug #16036 this area is woefully under-tested. Add
fairly extensive tests for the combination.
Backpatch back to 9.6 - before that isolationtester was not capable
enough. While we don't backpatch tests all the time, future fixes to
trigger.c would potentially look different enough in 12+ from the
earlier branches that introducing bugs during backpatching is more
likely than normal. Also, it's just a crucial and undertested area of
the code.
Author: Andres Freund
Discussion: https://postgr.es/m/16036-28184c90d952fb7f@postgresql.org
Backpatch: 9.6-, the earliest these tests work
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/04619f508fbfc7acf29d7c0aaddc2a65622b8aa0
Modified Files
--------------
.../isolation/expected/eval-plan-qual-trigger.out | 2587 ++++++++++++++++++++
src/test/isolation/isolation_schedule | 1 +
.../isolation/specs/eval-plan-qual-trigger.spec | 409 ++++
3 files changed, 2997 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-10-05 04:45:26 | pgsql: Disable one set of tests from c8841199509. |
Previous Message | Andres Freund | 2019-10-04 21:37:06 | pgsql: Add isolation tests for the combination of EPQ and triggers. |