pgsql: Fix issues in pg_rewind with --no-ensure-shutdown/--write-recove

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix issues in pg_rewind with --no-ensure-shutdown/--write-recove
Date: 2019-10-04 07:20:17
Message-ID: E1iGHsv-0003Yu-FA@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix issues in pg_rewind with --no-ensure-shutdown/--write-recovery-conf

This fixes two issues with recent features added in pg_rewind:
- --dry-run should do nothing on the target directory, but 927474c
forgot to consider that for --write-recovery-conf.
- --no-ensure-shutdown was not actually working. There is no test
coverage for this option yet, but a subsequent patch will add that.

Author: Alexey Kondratov
Discussion: https://postgr.es/m/7ca88204-3e0b-2f4c-c8af-acadc4b266e5@postgrespro.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6837632b758e0470a2692d9f8303e8aebd6fbd8f

Modified Files
--------------
src/bin/pg_rewind/pg_rewind.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Christoph Berg 2019-10-04 09:56:31 Re: pgsql: Remove pqsignal() from libpq's official exports list.
Previous Message Amit Kapila 2019-10-04 03:08:07 Re: pgsql: pgbench: add --partitions and --partition-method options.