pgsql: Fix lockmode initialization for custom relation options

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix lockmode initialization for custom relation options
Date: 2019-09-27 00:32:12
Message-ID: E1iDeBA-0006dv-Oz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix lockmode initialization for custom relation options

The code was enforcing AccessExclusiveLock for all custom relation
options, which is incorrect as the APIs allow a custom lock level to be
set.

While on it, fix a couple of inconsistencies in the tests and the README
of dummy_index_am.

Oversights in commit 773df88.

Discussion: https://postgr.es/m/20190925234152.GA2115@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fbfa5664882c9b61428266e6fb0d48b0147c421a

Modified Files
--------------
src/backend/access/common/reloptions.c | 7 -------
src/test/modules/dummy_index_am/README | 1 +
src/test/modules/dummy_index_am/expected/reloptions.out | 4 +++-
src/test/modules/dummy_index_am/sql/reloptions.sql | 1 +
4 files changed, 5 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-09-27 00:32:23 Re: pgsql: Support reloptions of enum type
Previous Message Peter Eisentraut 2019-09-26 19:55:19 pgsql: doc: Fix whitespace in markup