pgsql: Revert "Add DECLARE STATEMENT support to ECPG."

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Add DECLARE STATEMENT support to ECPG."
Date: 2019-09-20 16:47:54
Message-ID: E1iBM4Y-0000CU-RJ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Add DECLARE STATEMENT support to ECPG."

This reverts commit bd7c95f0c1a38becffceb3ea7234d57167f6d4bf,
along with assorted follow-on fixes. There are some questions
about the definition and implementation of that statement, and
we don't have time to resolve them before v13 release. Rather
than ship the feature and then have backwards-compatibility
concerns constraining any redesign, let's remove it for now
and try again later.

Discussion: https://postgr.es/m/TY2PR01MB2443EC8286995378AEB7D9F8F5B10@TY2PR01MB2443.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/96b6c82c9dd4a6a91c7e54bf42d36da111959ec6

Modified Files
--------------
doc/src/sgml/ecpg.sgml | 196 +------
src/interfaces/ecpg/ecpglib/Makefile | 2 +-
src/interfaces/ecpg/ecpglib/connect.c | 6 -
src/interfaces/ecpg/ecpglib/cursor.c | 261 ---------
src/interfaces/ecpg/ecpglib/descriptor.c | 15 +-
src/interfaces/ecpg/ecpglib/ecpglib_extern.h | 21 -
src/interfaces/ecpg/ecpglib/error.c | 7 -
src/interfaces/ecpg/ecpglib/execute.c | 25 +-
src/interfaces/ecpg/ecpglib/exports.txt | 4 -
src/interfaces/ecpg/ecpglib/prepare.c | 266 +--------
src/interfaces/ecpg/include/ecpgerrno.h | 1 -
src/interfaces/ecpg/include/ecpglib.h | 4 -
src/interfaces/ecpg/include/ecpgtype.h | 7 -
src/interfaces/ecpg/preproc/ecpg.addons | 77 +--
src/interfaces/ecpg/preproc/ecpg.c | 86 +--
src/interfaces/ecpg/preproc/ecpg.header | 1 -
src/interfaces/ecpg/preproc/ecpg.trailer | 34 --
src/interfaces/ecpg/preproc/ecpg.type | 1 -
src/interfaces/ecpg/preproc/output.c | 157 +-----
src/interfaces/ecpg/preproc/preproc_extern.h | 3 -
src/interfaces/ecpg/preproc/type.h | 8 -
src/interfaces/ecpg/test/ecpg_schedule | 1 -
.../ecpg/test/expected/compat_informix-sqlda.c | 12 +-
.../test/expected/compat_informix-test_informix.c | 4 +-
.../ecpg/test/expected/compat_oracle-char_array.c | 6 +-
.../ecpg/test/expected/pgtypeslib-nan_test.c | 18 +-
.../ecpg/test/expected/preproc-autoprep.c | 12 +-
src/interfaces/ecpg/test/expected/preproc-cursor.c | 76 +--
.../ecpg/test/expected/preproc-outofscope.c | 6 +-
.../ecpg/test/expected/preproc-variable.c | 6 +-
.../test/expected/preproc-whenever_do_continue.c | 6 +-
src/interfaces/ecpg/test/expected/sql-binary.c | 18 +-
src/interfaces/ecpg/test/expected/sql-declare.c | 595 ---------------------
.../ecpg/test/expected/sql-declare.stderr | 288 ----------
.../ecpg/test/expected/sql-declare.stdout | 20 -
src/interfaces/ecpg/test/expected/sql-desc.c | 12 +-
src/interfaces/ecpg/test/expected/sql-dyntest.c | 6 +-
src/interfaces/ecpg/test/expected/sql-execute.c | 12 +-
src/interfaces/ecpg/test/expected/sql-fetch.c | 16 +-
src/interfaces/ecpg/test/expected/sql-oldexec.c | 12 +-
src/interfaces/ecpg/test/expected/sql-quote.c | 4 +-
src/interfaces/ecpg/test/expected/sql-sqlda.c | 12 +-
src/interfaces/ecpg/test/sql/.gitignore | 2 -
src/interfaces/ecpg/test/sql/Makefile | 1 -
src/interfaces/ecpg/test/sql/declare.pgc | 207 -------
45 files changed, 173 insertions(+), 2361 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-09-20 18:23:06 pgsql: Fix some minor spec-compliance issues in jsonpath lexer.
Previous Message Alvaro Herrera 2019-09-20 16:19:45 Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL