pgsql: logical decoding: process ASSIGNMENT during snapshot build

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: logical decoding: process ASSIGNMENT during snapshot build
Date: 2019-09-13 19:40:17
Message-ID: E1i8rQX-00047D-O5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

logical decoding: process ASSIGNMENT during snapshot build

Most WAL records are ignored in early SnapBuild snapshot build phases.
But it's critical to process some of them, so that later messages have
the correct transaction state after the snapshot is completely built; in
particular, XLOG_XACT_ASSIGNMENT messages are critical in order for
sub-transactions to be correctly assigned to their parent transactions,
or at least one assert misbehaves, as reported by Ildar Musin.

Diagnosed-by: Masahiko Sawada
Author: Masahiko Sawada
Discussion: https://postgr.es/m/CAONYFtOv+Er1p3WAuwUsy1zsCFrSYvpHLhapC_fMD-zNaRWxYg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bac2fae05c7737530a6fe8276cd27d210d25c6ac

Modified Files
--------------
src/backend/replication/logical/decode.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-09-13 20:57:18 pgsql: Make tuplesort_set_bound() assertions more comprehensible, hopef
Previous Message Alvaro Herrera 2019-09-13 19:31:32 Re: pgsql: Fix progress reporting of CLUSTER / VACUUM FULL