pgsql: Be more careful about port selection in src/test/ldap/.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Be more careful about port selection in src/test/ldap/.
Date: 2019-09-09 18:22:10
Message-ID: E1i7OIk-0003IA-Kt@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more careful about port selection in src/test/ldap/.

Don't just assume that the next port is free; it might not be, or
if we're really unlucky it might even be out of the TCP range.
Do it honestly with two get_free_port() calls instead.

This is surely a pretty low-probability problem, but I think it
explains a buildfarm failure seen today, so let's fix it.

Back-patch to v11 where this script was added.

Discussion: https://postgr.es/m/25124.1568052346@sss.pgh.pa.us

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8459f908c6166e0249c310a03a3d1265ff7b7972

Modified Files
--------------
src/test/ldap/t/001_auth.pl | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2019-09-09 18:42:57 pgsql: Add _bt_binsrch() scantid assertion to nbtree.
Previous Message Andrew Dunstan 2019-09-09 13:04:52 pgsql: Prevent msys2 conversion of "cmd /c" switch to a file path