| From: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix handling of NULL distances in KNN-GiST |
| Date: | 2019-09-08 19:31:12 |
| Message-ID: | E1i72u0-0001Sl-E3@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix handling of NULL distances in KNN-GiST
In order to implement NULL LAST semantic GiST previously assumed distance to
the NULL value to be Inf. However, our distance functions can return Inf and
NaN for non-null values. In such cases, NULL LAST semantic appears to be
broken. This commit fixes that by introducing separate array of null flags for
distances.
Backpatch to all supported versions.
Discussion: https://postgr.es/m/CAPpHfdsNvNdA0DBS%2BwMpFrgwT6C3-q50sFVGLSiuWnV3FqOJuQ%40mail.gmail.com
Author: Alexander Korotkov
Backpatch-through: 9.4
Branch
------
REL9_4_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/1df4123048c49dda878bbe3b49616b0ff3b3dbe5
Modified Files
--------------
src/backend/access/gist/gistget.c | 70 +++++++++++++++++++++++++-------------
src/backend/access/gist/gistscan.c | 31 +++++++++++++----
src/include/access/gist_private.h | 25 ++++++++++++--
3 files changed, 93 insertions(+), 33 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-09-08 21:01:20 | pgsql: Fix RelationIdGetRelation calls that weren't bothering with erro |
| Previous Message | Alexander Korotkov | 2019-09-08 19:31:06 | pgsql: Fix handling Inf and Nan values in GiST pairing heap comparator |