| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | pgAdmin 4 commit: Ensure editable and read-only columns in Query Tool s |
| Date: | 2019-08-26 08:47:58 |
| Message-ID: | E1i2AfO-0000my-07@gothos.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Ensure editable and read-only columns in Query Tool should be identified by icons and tooltips in the column header. Fixes #4667
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8f7d5ac6fd1625ec8d27300b9a1c5319fc22446
Author: Yosry Muhammad <yosrym93(at)gmail(dot)com>
Modified Files
--------------
docs/en_US/editgrid.rst | 4 +-
docs/en_US/images/query_tool_editable_columns.png | Bin 0 -> 31676 bytes
docs/en_US/query_tool.rst | 22 +++-
docs/en_US/release_notes_4_13.rst | 3 +-
.../feature_tests/query_tool_journey_test.py | 72 ++++++++--
web/pgadmin/static/js/sqleditor_utils.js | 30 ++++-
web/pgadmin/tools/sqleditor/__init__.py | 45 ++-----
web/pgadmin/tools/sqleditor/command.py | 20 ++-
.../tools/sqleditor/static/css/sqleditor.css | 4 +-
web/pgadmin/tools/sqleditor/static/js/sqleditor.js | 38 ++++--
.../sqleditor/sql/default/get_columns.sql | 2 +-
.../tools/sqleditor/utils/get_column_types.py | 57 ++++++++
.../utils/is_query_resultset_updatable.py | 145 +++++++++++++++------
.../tests/test_is_query_resultset_updatable.py | 91 ++++++++++---
web/regression/feature_utils/locators.py | 8 ++
15 files changed, 411 insertions(+), 130 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2019-08-26 08:48:21 | Re: [GSoC][New Feature] Editable and Read-only Columns |
| Previous Message | Aditya Toshniwal | 2019-08-26 07:16:07 | [pgAdmin][RM4577] "string indices must be integers" displayed if click on PostgreSQL internal columns |