From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Back off output precision in circle.sql regression test. |
Date: | 2019-08-25 16:15:12 |
Message-ID: | E1i1vAe-0004g8-GA@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Back off output precision in circle.sql regression test.
We were setting extra_float_digits = 0 to avoid platform-dependent
output in this test, but that's still able to expose platform-specific
roundoff behavior in some new test cases added by commit a3d284485,
as reported by Peter Eisentraut. Reduce it to -1 to hide that.
(Over in geometry.sql, we're using -3, which is an ancient decision
dating to 337f73b1b. I wonder whether that's overkill now. But
there's probably little value in trying to change it.)
Back-patch to v12 where a3d284485 came in; there's no evidence that
we have any platform-dependent issues here before that.
Discussion: https://postgr.es/m/15551268-e224-aa46-084a-124b64095ee3@2ndquadrant.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cd714b3507c914e78d47352d1e126b4bec4380ad
Modified Files
--------------
src/test/regress/expected/circle.out | 15 ++++++++-------
src/test/regress/sql/circle.sql | 5 +++--
2 files changed, 11 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-08-25 19:04:41 | pgsql: Avoid platform-specific null pointer dereference in psql. |
Previous Message | Thomas Munro | 2019-08-25 02:54:42 | pgsql: Don't rely on llvm::make_unique. |