pgsql: Detect unused steps in isolation specs and do some cleanup

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Detect unused steps in isolation specs and do some cleanup
Date: 2019-08-24 02:52:51
Message-ID: E1i1MAd-0005cr-TR@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Detect unused steps in isolation specs and do some cleanup

This is useful for developers to find out if an isolation spec is
over-engineered or if it needs more work by warning at the end of a
test run if a step is not used, generating a failure with extra diffs.

While on it, clean up all the specs which include steps not used in any
permutations to simplify them.

Author: Michael Paquier
Reviewed-by: Asim Praveen, Melanie Plageman
Discussion: https://postgr.es/m/20190819080820.GG18166@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/989d23b04beac0c26f44c379b04ac781eaa4265e

Modified Files
--------------
src/test/isolation/isolationtester.c | 19 ++++++++++++++++++-
src/test/isolation/isolationtester.h | 1 +
src/test/isolation/specparse.y | 1 +
src/test/isolation/specs/freeze-the-dead.spec | 3 ---
.../isolation/specs/insert-conflict-do-nothing.spec | 1 -
.../isolation/specs/insert-conflict-do-update-2.spec | 1 -
.../isolation/specs/insert-conflict-do-update.spec | 1 -
src/test/isolation/specs/sequence-ddl.spec | 1 -
.../specs/tuplelock-upgrade-no-deadlock.spec | 3 ---
9 files changed, 20 insertions(+), 11 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Stephen Frost 2019-08-24 03:07:49 Re: pgsql: Detect unused steps in isolation specs and do some cleanup
Previous Message Michael Paquier 2019-08-24 02:36:15 pgsql: Remove dry-run mode from isolationtester