| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Use PageIndexTupleOverwrite() within nbtree. |
| Date: | 2019-08-13 18:57:00 |
| Message-ID: | E1hxbye-0007vS-Ow@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Use PageIndexTupleOverwrite() within nbtree.
Use the PageIndexTupleOverwrite() bufpage.c routine within nbtree
instead of deleting a tuple and re-inserting its replacement. This
makes the intent of affected code slightly clearer. It also makes
CREATE INDEX slightly faster, since there is no longer a need to shift
every leaf page's line pointer array back and forth during index builds.
Author: Peter Geoghegan, Anastasia Lubennikova
Reviewed-By: Anastasia Lubennikova
Discussion: https://postgr.es/m/CAH2-Wz=Zk=B9+Vwm376WuO7YTjFc2SSskifQm4Nme3RRRPtOSQ@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/af0ba49809b57203d87702b315b64f1fd53c728d
Modified Files
--------------
src/backend/access/nbtree/nbtpage.c | 9 ++++-----
src/backend/access/nbtree/nbtsort.c | 21 ++++++---------------
2 files changed, 10 insertions(+), 20 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-08-13 20:58:49 | pgsql: Un-break pg_dump for pre-8.3 source servers. |
| Previous Message | Alvaro Herrera | 2019-08-13 15:22:04 | pgsql: Don't constraint-exclude partitioned tables as much |