From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Run UTF8-requiring collation tests by default |
Date: | 2019-07-31 07:53:11 |
Message-ID: | E1hsjQ7-0002Vz-9n@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Run UTF8-requiring collation tests by default
The tests collate.icu.utf8 and collate.linux.utf8 were previously only
run when explicitly selected via EXTRA_TESTS. They require a UTF8
database, because the error messages in the expected files refer to
that, and they use some non-ASCII characters in the tests. Since
users can select any locale and encoding for the regression test run,
it was not possible to include these tests automatically.
To fix, use psql's \if facility to check various prerequisites such as
platform and the server encoding and quit the tests at the very
beginning if the configuration is not adequate. We then need to
maintain alternative expected files for these tests, but they are very
tiny and never need to change after this.
These two tests are now run automatically as part of the regression
tests.
Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://www.postgresql.org/message-id/flat/052295c2-a2e1-9a21-bd36-8fbff8686cf3%402ndquadrant.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f140007050a2ba874b85c4578d8417828f4b64b6
Modified Files
--------------
doc/src/sgml/regress.sgml | 8 --------
src/test/regress/expected/collate.icu.utf8.out | 7 +++++++
src/test/regress/expected/collate.icu.utf8_1.out | 9 +++++++++
src/test/regress/expected/collate.linux.utf8.out | 7 +++++++
src/test/regress/expected/collate.linux.utf8_1.out | 11 +++++++++++
src/test/regress/parallel_schedule | 5 +++--
src/test/regress/serial_schedule | 2 ++
src/test/regress/sql/collate.icu.utf8.sql | 8 ++++++++
src/test/regress/sql/collate.linux.utf8.sql | 8 ++++++++
9 files changed, 55 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-07-31 19:43:17 | pgsql: Fix pg_dump's handling of dependencies for custom opclasses. |
Previous Message | Andres Freund | 2019-07-31 07:16:28 | pgsql: Remove superfluous newlines in function prototypes. |