pgsql: Print WAL position correctly in pg_rewind error message.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Print WAL position correctly in pg_rewind error message.
Date: 2019-07-30 18:15:55
Message-ID: E1hsWfD-00053K-Me@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Print WAL position correctly in pg_rewind error message.

This has been wrong ever since pg_rewind was added. The if-branch just
above this, where we print the same error with an extra message supplied
by XLogReadRecord() got this right, but the variable name was wrong in the
else-branch. As a consequence, the error printed the WAL position as
0/0 if there was an error reading a WAL file.

Backpatch to 9.5, where pg_rewind was added.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/a6380f8a4b424cf097a066b45b91fa43d367c562

Modified Files
--------------
src/bin/pg_rewind/parsexlog.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2019-07-30 19:19:16 pgsql: Allow table AM's to use rd_amcache, too.
Previous Message Tomas Vondra 2019-07-30 18:07:32 pgsql: Don't build extended statistics on inheritance trees