From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor checks for deleted GiST pages. |
Date: | 2019-07-24 17:27:27 |
Message-ID: | E1hqL31-00010m-Rv@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor checks for deleted GiST pages.
The explicit check in gistScanPage() isn't currently really necessary, as
a deleted page is always empty, so the loop would fall through without
doing anything, anyway. But it's a marginal optimization, and it gives a
nice place to attach a comment to explain how it works.
Backpatch to v12, where GiST page deletion was introduced.
Reviewed-by: Andrey Borodin
Discussion: https://www.postgresql.org/message-id/835A15A5-F1B4-4446-A711-BF48357EB602%40yandex-team.ru
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9eb5607e69933f0a88b6774d1ba728f27afdbd3d
Modified Files
--------------
src/backend/access/gist/gist.c | 40 +++++++++++++++------------------------
src/backend/access/gist/gistget.c | 14 ++++++++++++++
2 files changed, 29 insertions(+), 25 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2019-07-24 18:17:14 | Re: pgsql: Improve stability of TAP test for synchronous replication |
Previous Message | Andrew Dunstan | 2019-07-24 15:49:16 | pgsql: Don't assume expr is available in pgbench tests |