From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Clarify the distinction between public and private SPITupleTable |
Date: | 2019-07-17 18:55:17 |
Message-ID: | E1hnp5B-0006LF-IY@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Clarify the distinction between public and private SPITupleTable fields.
The fields that we consider public are "tupdesc" and "vals", which
historically are in the middle of the struct. Move them to the front
(this should be perfectly safe to do in HEAD) and add comments to make
it quite clear which fields are public or not.
Also adjust spi.sgml's documentation of the struct to match.
That doc had bit-rotted somewhat, as it was missing some fields.
(Arguably we should just remove all the private fields from the docs,
but for now I refrained.)
Daniel Gustafsson, reviewed by Fabien Coelho
Discussion: https://postgr.es/m/0D19F836-B743-4340-B6A2-F148CA3DD1F0@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/fec0778c8098cebec2d5cb3674ac7151d8d95638
Modified Files
--------------
doc/src/sgml/spi.sgml | 21 +++++++++++++--------
src/include/executor/spi.h | 7 +++++--
2 files changed, 18 insertions(+), 10 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-07-17 22:26:45 | pgsql: Sync our copy of the timezone library with IANA release tzcode20 |
Previous Message | Tom Lane | 2019-07-17 17:13:20 | pgsql: Doc: explain where to find Makefile used to build sepgsql-regtes |