From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix pg_mcv_list_items() to produce text[] |
Date: | 2019-07-05 15:55:28 |
Message-ID: | E1hjQYa-0007zX-0S@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix pg_mcv_list_items() to produce text[]
The function pg_mcv_list_items() returns values stored in MCV items. The
items may contain columns with different data types, so the function was
generating text array-like representation, but in an ad-hoc way without
properly escaping various characters etc.
Fixed by simply building a text[] array, which also makes it easier to
use from queries etc.
Requires changes to pg_proc entry, so bump catversion.
Backpatch to 12, where multi-column MCV lists were introduced.
Author: Tomas Vondra
Reviewed-by: Dean Rasheed
Discussion: https://postgr.es/m/20190618205920.qtlzcu73whfpfqne@development
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/cc052b423ad7dc92abb3461a096408c3997c36e1
Modified Files
--------------
src/backend/statistics/mcv.c | 128 ++++++++++++--------------------
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_proc.dat | 2 +-
src/test/regress/expected/stats_ext.out | 6 +-
4 files changed, 51 insertions(+), 87 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-07-05 16:32:59 | pgsql: Add \warn command to psql. |
Previous Message | Thomas Munro | 2019-07-05 09:05:48 | pgsql: Improve comment in postgresql.conf.sample. |