| From: | Etsuro Fujita <efujita(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: postgres_fdw: Remove redundancy in postgresAcquireSampleRowsFunc |
| Date: | 2019-07-03 08:56:51 |
| Message-ID: | E1hib4N-0001Qx-VO@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
postgres_fdw: Remove redundancy in postgresAcquireSampleRowsFunc().
Previously, in the loop in postgresAcquireSampleRowsFunc() to iterate
fetching rows from a given remote table, we redundantly 1) determined the
fetch size by parsing the table's server/table-level options and then 2)
constructed the fetch command; remove that redundancy.
Author: Etsuro Fujita
Reviewed-by: Julien Rouhaud
Discussion: https://postgr.es/m/CAPmGK17_urk9qkLV65_iYMFw64z5qhdfhY=tMVV6Jg4KNYx8+w@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2a1612104cadbfdc739ff0370f279779f323c3b5
Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 63 ++++++++++++++++++++-----------------
1 file changed, 34 insertions(+), 29 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2019-07-03 11:48:45 | pgsql: Don't remove surplus columns from GROUP BY for inheritance paren |
| Previous Message | Michael Meskes | 2019-07-03 01:17:23 | pgsql: Made ecpg compatibility mode and run-time behaviour options case |