| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Refactor code of reindexdb for query generation |
| Date: | 2019-07-02 02:44:20 |
| Message-ID: | E1hi8mK-0007W1-1O@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Refactor code of reindexdb for query generation
This merges the portion related to REINDEX SYSTEM into the routine
already available for all the other reindex types, making the query
generation cleaner. While on it, change the handling of the reindex
types using an enum, which allows to get rid of the hardcoded strings
used directly in the query generation present for the same purpose (aka
"TABLE", "DATABASE", etc.).
Per discussion with Julien Rouhaud, Tom Lane, Alvaro Herrera and me.
Author: Julien Rouhaud
Discussion: https://postgr.es/m/CAOBaU_bSmSik_WRK9niDnm-3NkNZky6+uKxkmQwvthZvMWpS5A@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/9adda24543e354317abf5400d7e7d3961a93bce6
Modified Files
--------------
src/bin/scripts/reindexdb.c | 164 +++++++++++++++++++++------------------
src/tools/pgindent/typedefs.list | 1 +
2 files changed, 90 insertions(+), 75 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-07-02 05:09:29 | pgsql: Add support for Visual Studio 2019 in build scripts |
| Previous Message | Tom Lane | 2019-07-01 23:48:40 | pgsql: Revert "Insert temporary debugging output in regression tests." |