pgsql: Fix description of WAL record XLOG_BTREE_META_CLEANUP

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix description of WAL record XLOG_BTREE_META_CLEANUP
Date: 2019-06-19 02:03:09
Message-ID: E1hdPwL-0006GX-Aj@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix description of WAL record XLOG_BTREE_META_CLEANUP

This record uses one metadata buffer and registers some data associated
to the buffer, but when parsing the record for its description a direct
access to the record data was done, but there is none. This leads
usually to an incorrect description, but can also cause crashes like in
pg_waldump. Instead, fix things so as the parsing uses the data
associated to the metadata block.

This is an oversight from 3d92796, so backpatch down to 11.

Author: Michael Paquier
Description: https://postgr.es/m/20190617013059.GA3153@paquier.xyz
Backpatch-through: 11

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3c28fd2281223580b88473e5145b752cc7cbadf9

Modified Files
--------------
src/backend/access/rmgrdesc/nbtdesc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-06-19 02:19:23 pgsql: Remove last references to WAL segment size in MSVC scripts
Previous Message Andres Freund 2019-06-18 22:55:37 pgsql: Fix memory corruption/crash in ANALYZE.