pgsql: Make cpluspluscheck more portable.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Make cpluspluscheck more portable.
Date: 2019-06-02 17:45:13
Message-ID: E1hXUXh-00032p-J5@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Make cpluspluscheck more portable.

Teach it to scrape -I and -D switches from CPPFLAGS in Makefile.global.
This is useful for testing on, eg, FreeBSD, where you won't get far
without "-I/usr/local/include".

Also, expand the set of blacklisted-for-unportability atomics headers,
based on noting that arch-x86.h fails to compile on an ARM box. The
other ones I'd omitted seem to compile all right on architectures they
don't belong to, but that's surely too shaky to rely on. Let's do
like we did for the src/include/port/ headers, and ignore all except
the variant that's pulled in by the arch-independent header.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f4755a2c01486519cfce5b21ab04529ad26f5ed1

Modified Files
--------------
src/tools/pginclude/cpluspluscheck | 20 +++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-06-03 02:03:39 pgsql: Fix some issues and improve psql completion for access methods
Previous Message Tom Lane 2019-06-02 16:23:46 pgsql: Clean up PL/Perl's handling of the _() macro.