From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Un-break ecpg tests for Windows. |
Date: | 2019-06-02 15:13:39 |
Message-ID: | E1hXSB1-00005G-GP@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Un-break ecpg tests for Windows.
Declaring a function "inline" still doesn't work with Windows compilers
(C99? what's that?), unless the macro provided by pg_config.h is
in-scope, which it is not in our ECPG test programs. So the workaround
I tried to use in commit 7640f9312 doesn't work for Windows. Revert
the change in printf_hack.h, and instead just blacklist that file
in cpluspluscheck --- since it's a not-installed test file, we don't
really need to verify its C++ cleanliness anyway.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/10a53cae9993abae159abdc6a76e46f6aac120d1
Modified Files
--------------
src/interfaces/ecpg/test/expected/compat_informix-dec_test.c | 2 +-
src/interfaces/ecpg/test/expected/pgtypeslib-num_test.c | 2 +-
src/interfaces/ecpg/test/expected/pgtypeslib-num_test2.c | 2 +-
src/interfaces/ecpg/test/printf_hack.h | 2 +-
src/tools/pginclude/cpluspluscheck | 2 ++
5 files changed, 6 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2019-06-02 16:23:46 | pgsql: Clean up PL/Perl's handling of the _() macro. |
Previous Message | Alvaro Herrera | 2019-06-02 04:34:42 | pgsql: Increase test coverage for worker_spi by % |