From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Make error logging in extended statistics more consistent |
Date: | 2019-05-30 15:07:13 |
Message-ID: | E1hWMe9-0005eY-Pu@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Make error logging in extended statistics more consistent
Most errors reported in extended statistics are internal issues, and so
should use elog(). The MCV list code was already following this rule, but
the functional dependencies and ndistinct coefficients were using a mix
of elog() and ereport(). Fix this by changing most places to elog(), with
the exception of input functions.
This is a mostly cosmetic change, it makes the life a little bit easier
for translators, as elog() messages are not translated. So backpatch to
PostgreSQL 10, where extended statistics were introduced.
Author: Tomas Vondra
Backpatch-through: 10 where extended statistics were added
Discussion: https://postgr.es/m/20190503154404.GA7478@alvherre.pgsql
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/39c9efc15646b3eb36d4095c3657405894dc3ea4
Modified Files
--------------
src/backend/statistics/dependencies.c | 4 +---
src/backend/statistics/mvdistinct.c | 22 +++++++---------------
2 files changed, 8 insertions(+), 18 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-05-30 20:45:46 | pgsql: Remove unnecessary (and wrong) forward declaration. |
Previous Message | Tomas Vondra | 2019-05-30 15:07:04 | pgsql: Make error logging in extended statistics more consistent |