From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: In the pg_upgrade test suite, don't write to src/test/regress. |
Date: | 2019-05-28 20:09:20 |
Message-ID: | E1hViPQ-0005wb-M7@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
In the pg_upgrade test suite, don't write to src/test/regress.
When this suite runs installcheck, redirect file creations from
src/test/regress to src/bin/pg_upgrade/tmp_check/regress. This closes a
race condition in "make -j check-world". If the pg_upgrade suite wrote
to a given src/test/regress/results file in parallel with the regular
src/test/regress invocation writing it, a test failed spuriously. Even
without parallelism, in "make -k check-world", the suite finishing
second overwrote the other's regression.diffs. This revealed test
"largeobject" assuming @abs_builddir@ is getcwd(), so fix that, too.
Buildfarm client REL_10, released fifty-four days ago, supports saving
regression.diffs from its new location. When an older client reports a
pg_upgradeCheck failure, it will no longer include regression.diffs.
Back-patch to 9.5, where pg_upgrade moved to src/bin.
Reviewed (in earlier versions) by Andrew Dunstan.
Discussion: https://postgr.es/m/20181224034411.GA3224776@rfd.leadboat.com
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/5c0fee0be2f64439149a37bc4bc4f44b1fcdcda8
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 11 +++++++++++
src/test/regress/input/largeobject.source | 6 +++---
src/test/regress/output/largeobject.source | 6 +++---
src/test/regress/output/largeobject_1.source | 6 +++---
src/tools/msvc/vcregress.pl | 21 ++++++++++++++++++---
5 files changed, 38 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2019-05-28 21:36:46 | pgsql: Fix typo in message |
Previous Message | Andres Freund | 2019-05-28 16:09:12 | pgsql: v12 release notes: Correct contributor name. |