From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi |
Date: | 2019-05-23 22:09:49 |
Message-ID: | E1hTvuH-0002n8-Ly@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_upgrade: Make test.sh's installcheck use to-be-upgraded version's bindir.
On master (after 700538) the old version's installed psql was used -
even when the old version might not actually be installed / might be
installed into a temporary directory. As commonly the case when just
executing make check for pg_upgrade, as $oldbindir is just the current
version's $bindir.
In the back branches, with --install specified, psql from the new
version's temporary installation was used, without --install (e.g for
NO_TEMP_INSTALL, cf 47b3c26642), the new version's installed psql was
used (which might or might not exist).
Author: Andres Freund
Discussion: https://postgr.es/m/20190522175150.c26f4jkqytahajdg@alap3.anarazel.de
Branch
------
REL9_5_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7ac46b1ae940f85e5a41a5666f8e0a61912a8314
Modified Files
--------------
src/bin/pg_upgrade/test.sh | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2019-05-23 22:09:51 | pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi |
Previous Message | Andres Freund | 2019-05-23 22:09:48 | pgsql: pg_upgrade: Make test.sh's installcheck use to-be-upgraded versi |