pgsql: Fix ordering of GRANT commands in pg_dumpall for tablespaces

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix ordering of GRANT commands in pg_dumpall for tablespaces
Date: 2019-05-23 01:51:01
Message-ID: E1hTcsn-0004O7-L1@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix ordering of GRANT commands in pg_dumpall for tablespaces

This uses a method similar to 68a7c24f and now b8c6014 (applied for
database creation), which guarantees that GRANT commands using the WITH
GRANT OPTION are dumped in a way so as cascading dependencies are
respected. Note that tablespaces do not have support for initial
privileges via pg_init_privs, so the same method needs to be applied
again. It would be nice to merge all the logic generating ACL queries
in dumps under the same banner, but this requires extending the support
of pg_init_privs to objects that cannot use it yet, so this is left as
future work.

Discussion: https://postgr.es/m/20190522071555.GB1278@paquier.xyz
Author: Michael Paquier
Reviewed-by: Nathan Bossart
Backpatch-through: 9.6

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/156c0c2dff403fd115f3a5f6d73ab80959c84129

Modified Files
--------------
src/bin/pg_dump/pg_dumpall.c | 33 ++++++++++++++++++++++++++-------
1 file changed, 26 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Gierth 2019-05-23 14:49:28 pgsql: Fix array size allocation for HashAggregate hash keys.
Previous Message Michael Paquier 2019-05-23 00:42:26 pgsql: Remove -o/--oids from pg_dumpall