pgsql: Remove pg_rewind's private logging.h/logging.c files.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove pg_rewind's private logging.h/logging.c files.
Date: 2019-05-14 17:11:37
Message-ID: E1hQaxl-00060S-5z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove pg_rewind's private logging.h/logging.c files.

The existence of these files became rather confusing with the
introduction of a widely-known logging.h header in commit cc8d41511.
(Indeed, there's already some duplicative #includes here, perhaps
betraying such confusion.) The only thing left in them, after that
commit, is a progress-reporting function that's neither general-purpose
nor tied in any way to other logging infrastructure. Hence, let's just
move that function to pg_rewind.c, and get rid of the separate files.

Discussion: https://postgr.es/m/3971.1557787914@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/53ddefbaf8a0493d2c1fa0b18bfaba72da556985

Modified Files
--------------
src/bin/pg_rewind/Makefile | 2 +-
src/bin/pg_rewind/copy_fetch.c | 1 -
src/bin/pg_rewind/file_ops.c | 1 -
src/bin/pg_rewind/filemap.c | 2 --
src/bin/pg_rewind/libpq_fetch.c | 2 --
src/bin/pg_rewind/logging.c | 79 -----------------------------------------
src/bin/pg_rewind/logging.h | 25 -------------
src/bin/pg_rewind/nls.mk | 2 +-
src/bin/pg_rewind/parsexlog.c | 1 -
src/bin/pg_rewind/pg_rewind.c | 62 ++++++++++++++++++++++++++++++--
src/bin/pg_rewind/pg_rewind.h | 12 +++++++
src/bin/pg_rewind/timeline.c | 1 -
12 files changed, 74 insertions(+), 116 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2019-05-14 17:32:07 pgsql: docs: Indent listitem tags in PG 12 release notes
Previous Message Tom Lane 2019-05-14 15:27:36 pgsql: Fix SQL-style substring() to have spec-compliant greediness beha