pgsql: In bootstrap mode, use default signal handling for SIGINT etc.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: In bootstrap mode, use default signal handling for SIGINT etc.
Date: 2019-05-14 14:22:36
Message-ID: E1hQYKC-0002Yk-HS@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

In bootstrap mode, use default signal handling for SIGINT etc.

Previously, the code pointed the standard process-termination signals
to postgres.c's die(). That would typically result in an attempt to
execute a transaction abort, which is not possible in bootstrap mode,
leading to PANIC. This choice seems to be a leftover from an old code
structure in which the same signal-assignment code was used for many
sorts of auxiliary processes, including interactive standalone
backends. It's not very sensible for bootstrap mode, which has no
interest in either interactivity or continuing after an error. We can
get better behavior with less effort by just letting normal process
termination happen, after which the parent initdb process will clean up.

This is basically cosmetic in any case, since initdb will react the
same way whether bootstrap dies on a signal or abort(). Given the
lack of previous complaints, I don't feel a need to back-patch,
even though the behavior is old.

Discussion: https://postgr.es/m/3850b11a.5121.16aaf827e4a.Coremail.thunder1@126.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/fb489e4b3195fc33cccc0fd308e5a0ab502cf199

Modified Files
--------------
src/backend/bootstrap/bootstrap.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2019-05-14 15:27:36 pgsql: Fix SQL-style substring() to have spec-compliant greediness beha
Previous Message Peter Eisentraut 2019-05-14 13:51:40 pgsql: Update information_schema for SQL:2016