From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix logical replication's ideas about which type OIDs are built- |
Date: | 2019-05-13 21:23:15 |
Message-ID: | E1hQIPj-0007LF-Ka@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix logical replication's ideas about which type OIDs are built-in.
Only hand-assigned type OIDs should be presumed to match across different
PG servers; those assigned during genbki.pl or during initdb are likely
to change due to addition or removal of unrelated objects.
This means that the cutoff should be FirstGenbkiObjectId (in HEAD)
or FirstBootstrapObjectId (before that), not FirstNormalObjectId.
Compare postgres_fdw's is_builtin() test.
It's likely that this error has no observable consequence in a
normally-functioning system, since ATM the only affected type OIDs are
system catalog rowtypes and information_schema types, which would not
typically be interesting for logical replication. But you could
probably break it if you tried hard, so back-patch.
Discussion: https://postgr.es/m/15150.1557257111@sss.pgh.pa.us
Branch
------
REL_10_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/3b505036a129af5bbbf40a00f8997fc15438bb38
Modified Files
--------------
src/backend/replication/logical/relation.c | 2 +-
src/backend/replication/pgoutput/pgoutput.c | 10 +++++++---
2 files changed, 8 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2019-05-13 22:39:26 | pgsql: Doc: Refer to line pointers as item identifiers. |
Previous Message | Peter Geoghegan | 2019-05-13 17:28:41 | pgsql: Don't leave behind junk nbtree pages during split. |